Code review comment for lp:~saviq/unity/phablet.flatten-qmltests

Revision history for this message
Michi Henning (michihenning) wrote :

 if("${qmltest_NO_ADD_TEST}" STREQUAL FALSE AND NOT "${qmltest_DEFAULT_NO_ADD_TEST}" STREQUAL "TRUE")
          add_test(${qmltest_TARGET} make ${qmltest_TARGET})

Calling make directly like this prevents building with other build tools, such as ninja. I think the correct way to do this is to a custom target with a DEPENDS. Jussi?

« Back to merge proposal