Code review comment for lp:~saviq/unity-api/add-shell-notifications-api

Revision history for this message
Michi Henning (michihenning) wrote :

One more thing: "make cppcheck" reports one function that is never called (see below). The tests should exercise it, I would think?

For those functions that we truly don't want to exercise (any?), an inline suppression can be used, such as:

void
// cppcheck-suppress unusedFunction
Myclass::
foo()
{
}

I'll submit a separate MR to change the way cppcheck is called to include the name of the error in the output, so it's easy to add a suppression if we need one.

$ make cppcheck
/home/michi/src/add-shell-notifications-api/test/mocks/plugins/Unity/Notifications/Mocks/MockActionModel.cpp ( 36 ) : style ( unusedFunction ) : The function 'rowCount' is never used.
Built target cppcheck

review: Needs Fixing

« Back to merge proposal