Code review comment for lp:~saviq/unity-2d/titlebar-dblclick

Revision history for this message
Alberto Mardegan (mardy) wrote :

Great work, Michał!
The double click part seems to work quite reliably; however, I noticed a very strange behaviour with the dragging: if you drag the mouse cursor over the indicators (be it the applets, or the application menus) and then continue dragging down and immediately stop as soon as the window gets unmaximized, the mouse cursor remains in its "dragging" form, and all keyboard input seems to be disabled (for instance, you cannot switch desktop with Ctrl+Alt+Right) except for the ESC key, which brings the window back to the maximized mode.

Also, please adjust the coding style to put "*" and "&" next to the type name, and not next to the variable name.

review: Needs Fixing

« Back to merge proposal