> d->m_screenInfo needs to be deleted in Unity2dPanel::~Unity2dPanel (or give
> the ScreenInfo a parent when creating it)
> m_screenInfo needs to be initialized to NULL in
> Unity2DDeclarativeView::Unity2DDeclarativeView
> m_screenInfo needs to be delete in
> Unity2DDeclarativeView::~Unity2DDeclarativeView (or give the ScreenInfo a
> parent when creating it in the various children)
Done.
> Seems
> Q_ENUMS(WorkspacesOrientation)
> Q_ENUMS(WorkspacesCorner)
> are not used at all? I think they were "wrong" before already but since we're
> cleaning up, might make sense to kill them now too.
Yup, got rid of that.
Resubmitted from ~unity-2d-team so that you guys can work off of that when I'm away. Cheers!
> d->m_screenInfo needs to be deleted in Unity2dPanel: :~Unity2dPanel (or give iveView: :Unity2DDeclara tiveView iveView: :~Unity2DDeclar ativeView (or give the ScreenInfo a
> the ScreenInfo a parent when creating it)
> m_screenInfo needs to be initialized to NULL in
> Unity2DDeclarat
> m_screenInfo needs to be delete in
> Unity2DDeclarat
> parent when creating it in the various children)
Done.
> Seems WorkspacesOrien tation) WorkspacesCorne r)
> Q_ENUMS(
> Q_ENUMS(
> are not used at all? I think they were "wrong" before already but since we're
> cleaning up, might make sense to kill them now too.
Yup, got rid of that.
Resubmitted from ~unity-2d-team so that you guys can work off of that when I'm away. Cheers!