Ubuntu Settings Components

Code review comment for lp:~saviq/ubuntu-settings-components/packaging-cleanup

  1. packaging-cleanup
  2. Merge into trunk
Revision history for this message
Gerry Boland (gerboland) wrote :

We should really add QmlTest.cmake to cmake-extras.

I'm not a package expert, but the changes look just fine.

I noticed that plugins/Ubuntu/Settings/Fingerprint/utils/segment.py is Python2. But I don't see it being referred to anywhere, so must be a dev-only tool.

=== modified file 'debian/control'
+ Ubuntu settings components for Unity
Unity8?

I can't really fault anything. Nice work

review: Approve

« Back to merge proposal