Merge lp:~savilerow-team/savilerow/unity-scope-selfservicebill-lp1322337 into lp:~savilerow-team/savilerow/unity-scope-selfservicebill

Proposed by Scott Sweeny
Status: Merged
Merged at revision: 13
Proposed branch: lp:~savilerow-team/savilerow/unity-scope-selfservicebill-lp1322337
Merge into: lp:~savilerow-team/savilerow/unity-scope-selfservicebill
Diff against target: 25 lines (+7/-1)
2 files modified
data/selfservicebill.json (+1/-1)
debian/changelog (+6/-0)
To merge this branch: bzr merge lp:~savilerow-team/savilerow/unity-scope-selfservicebill-lp1322337
Reviewer Review Type Date Requested Status
Michał Karnicki (community) Approve
Review via email: mp+222044@code.launchpad.net

Description of the change

Populate the "link" fields of results with a non-empty string since the API seems to have become more strict lately.

Tested by cwayne on his phone.

To post a comment you must log in.
Revision history for this message
Michał Karnicki (karni) wrote :

Heh, that's pain.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'data/selfservicebill.json'
--- data/selfservicebill.json 2014-02-11 18:33:50 +0000
+++ data/selfservicebill.json 2014-06-04 13:46:10 +0000
@@ -1,6 +1,6 @@
1[1[
2 {2 {
3 "title": "$24.36 which will be collected on 28th Feb",3 "title": "$24.36 which will be collected on 28th Feb",
4 "link": ""4 "link": "http://www.ubuntu.com"
5 }5 }
6]6]
77
=== modified file 'debian/changelog'
--- debian/changelog 2014-03-27 02:26:42 +0000
+++ debian/changelog 2014-06-04 13:46:10 +0000
@@ -1,3 +1,9 @@
1unity-scope-selfservicebill (0.4) UNRELEASED; urgency=medium
2
3 * Don't use empty URLs for results (LP: #1322337)
4
5 -- Scott Sweeny <scott.sweeny@canonical.com> Wed, 04 Jun 2014 00:46:56 -0400
6
1unity-scope-selfservicebill (0.3) trusty; urgency=medium7unity-scope-selfservicebill (0.3) trusty; urgency=medium
28
3 * Update to new api9 * Update to new api

Subscribers

People subscribed via source and target branches

to all changes: