Code review comment for lp:~sateesh-chodapuneedi/nova/esx-multi-nic

Revision history for this message
Sateesh (sateesh-chodapuneedi) wrote :

@Vish thanks for the review.

> 63 - bridge_interface = network['bridge_interface']
> 64 + vlan_interface = FLAGS.vmwareapi_vlan_interface
>
> can we just use the global vlan interface here?

I choose to use separate flag because vlan_interface is not being used in the current code base (revision 1526), also post multi-nic nova code started using bridge_interface in networks table rather than depending on this flag. From the information I have, it seems to me that this flag is going to become stale. So I thought of having a separate flag specific vmwareapi virt driver which deals with it's specific case. Even if vlan_interface flag gets removed no functionality breakage occur in vmwareapi virt driver. So trying to keep this flag modular (or module specific).
Also ESX(i) names it NIC with prefix 'vmnic', different from other systems that use prefix 'eth'. So I thought if we classify the flag by it's value, it becomes specific to vmware subset.

« Back to merge proposal