Code review comment for ~sankaraditya/cloud-init:vmware-customize-utc-time

Revision history for this message
Chad Smith (chad.smith) wrote :

So, I'm a hestant on this branch because cloud-init already surfaces a cc_timezone module which allows users to set timezone. That module talks to <distro>.set_timezone which in turn calls <distro>._find_timezone_file.

Growing that functionality in vmware-specific modules seems to be duplicating the user-facing configuration that cloud-init timsurfaces. Why wouldn't vmware providie timzone: UTC as vendor data?

If you need something specific for debian, or other distros that isn't handled by the Distro class, I'd recommend extending the distro class specifically to get this functionality instead of having distro-specific logic down in cloudinit/sources/helpers/vmware/imc/guestcust_util.py.

« Back to merge proposal