Code review comment for ~sankaraditya/cloud-init:topic-stanguturi-vmware-etc-hosts

Revision history for this message
Scott Moser (smoser) wrote :

Hi Sankar,

manage_etc_hosts is a real pain.
Setting this means that `hostname` will return 127.0.0.1. I assume your
motivation for doing this is to avoid the annoying 'sudo' warning.

Any change here breaks something, so I think it is best to tell the
user to opt in to this change. The primary reason that we do not
write a 127.0.1.1 address for 'hostname' is that ... for better
or worse, some applications (primarily java in my experience) will do
basically use the result of `hostname -f` and tell other
network applications that that is their address.

Ie, run a webserver, it says "Hey everyone, you can reach me at `hostname
-fqdn`" which then resolves to the localhost address, and then ...
doesn't work for anyone other than that host. See bug 871966 and bug
890501
for more info.

So.. I'd really rather not make this change as it *does* cause a
noticable change in behavior and would make Ubuntu on vmware different
than Ubuntu on other clouds.

The other change seems fine.

review: Needs Fixing

« Back to merge proposal