Juju Charms Collection
docker-compose package

Code review comment for lp:~samuel-cozannet/charms/trusty/docker-compose/dev

  1. Trusty Tahr (14.04)
  2. dev
  3. Merge into trunk
Revision history for this message
Charles Butler (lazypower) wrote :

+1 LGTM with this particular implementation.

I think we should move the docker-compose version identifier to config.yaml and let user config drive that, so the end user isn't blocked on us updating the charm. Otherwise LGTM

Thanks for the contribution Sam! Big thanks for the README updates, and the port-openening code. This is the first time i've seen shyaml, looks nifty.

review: Approve

« Back to merge proposal