Code review comment for lp:~samuel-buffet/entertainer/volume_management
Revision history for this message
| Samuel Buffet (samuel-buffet) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Devs,
With this branch it is now possible to change the volume level when playing a media. This is something important that was missing (I think).
To reach that goal, a "volume" property has been added to the media player.
A VolumeIndicator has also been created. It's themable and is displayed when we change the volume with a fade in effect while the screen is faded out at the same time.
The keys I've chosen to change the volume are l = volume down and m = volume up. If you prefer other keys just let me know.
The VolumeIndicator widget is not reactive right now (I'l do that in an other branch)
Samuel-