First, I'd like to thank you for all the efforts you put in this review. This really helps and I deeply appreciate.
In my last push, I've fixed all what you've already notice and more in the same spirit (mainly docstrings).
> a unified style in the codebase. The comments might seem a little rough
> because they are basically just my notes. I hope that they're readable enough.
No pb here, there are perfectly readable and not rough at all (I mean things have to be said)
> test_scrollmenu.py:
> * has an empty line with spaces.
> * testCreate should use a PEP8 method name. test_create (We use camel case
> for setUp and tearDown because that's what unittest does. Any existing test
> that we have that uses camel case is just because it's from a time before
Hmm, Matt I don't know what *camel* is about
Now, the good point is that after this review, everything will look more or less relax and easy ;)
Hi Matt,
First, I'd like to thank you for all the efforts you put in this review. This really helps and I deeply appreciate.
In my last push, I've fixed all what you've already notice and more in the same spirit (mainly docstrings).
> a unified style in the codebase. The comments might seem a little rough
> because they are basically just my notes. I hope that they're readable enough.
No pb here, there are perfectly readable and not rough at all (I mean things have to be said)
> test_scrollmenu.py:
> * has an empty line with spaces.
> * testCreate should use a PEP8 method name. test_create (We use camel case
> for setUp and tearDown because that's what unittest does. Any existing test
> that we have that uses camel case is just because it's from a time before
Hmm, Matt I don't know what *camel* is about
Now, the good point is that after this review, everything will look more or less relax and easy ;)
Samuel-