Code review comment for lp:~samuel-buffet/entertainer/bug_379824

Revision history for this message
Samuel Buffet (samuel-buffet) wrote :

Devs,

This is a fix I propose for the linked bug.

The bug was caused by a change made by google in the format of the returned result.

They've changed the way they give us the condition pictures.

Before we received things like that : '/images/weather/sunny.gif'.

And now we receive : '/ig/images/weather/sunny.gif'.

So I've fixed the code by spliting the result to only consider the short filename (without the relative path).

This will protect us to any change in the relative path.

I've added a tests also to get conditions from different cities on earth. This is to prevent from future change on short filenames this time.

Samuel-

« Back to merge proposal