Code review comment for lp:~sammyshp/flashlight-firmware/moon-dont-ramp-up

Revision history for this message
Selene ToyKeeper (toykeeper) wrote :

We took very similar approaches here, mostly differing in whether the boolean means "ramp" or "don't ramp". Also, yours has the nice property that the user can select either behavior at compile time, or add a menu item... while mine only offers the old behavior or a menu item.

I'm hoping to merge other branches at the moment, but I left a note in the code pointing back to this as a possible improvement for later, because it's a good idea.

« Back to merge proposal