Code review comment for lp:~sam-sgrs/ubuntu-filemanager-app/fix-1579487

Revision history for this message
Sam Segers (sam-sgrs) wrote :

But there are no samba headers in the project, so how is it building now if
thee Dev package can't be installed?
This change also downloads the development files the same way as the
included libs.

For the desktop, the main issue is the plugin loads libsmbclient, which in
turn loads numerous smb libs. Because libsmbclient is compiled with rpath
hard coded, it was loading the system smb libs which are xenial and the
bundled vivid.

So for the desktop only the rpath change is needed. Feel free to discard
the rest.

Op vr 26 aug. 2016 21:02 schreef Carlos Jose Mazieri <
<email address hidden>>:

> Hello Arto and Sam,
>
> The "apt-get install libsmbclient-dev" used to fail on any armf kit, so it
> was impossible to generate the click package in the qtcreator.
>
> The build on device used to work because "apt-get install
> libsmbclient-dev" on device used to work.
>
> That is the reason why Alan Pope and Stefano Verzegnassi came with
> solution of archiving samba libraries in the project.
>
> --
>
> https://code.launchpad.net/~sam-sgrs/ubuntu-filemanager-app/fix-1579487/+merge/303622
> You are the owner of lp:~sam-sgrs/ubuntu-filemanager-app/fix-1579487.
>

« Back to merge proposal