Code review comment for lp:~salvatore-orlando/nova/bug723301

Revision history for this message
termie (termie) wrote :

- line 251: please put one arg per line, or all on the same line on the next line, double indented
- please format all docstrings according to guide in HACKING
- line 258: perhaps assign the lambda on the line before and pass it in to this function instead of defining it inline here as it gets a bit messy
- line 526: dictionary contents on the same line as the opening parens, you can remove the comment and you doing foo[:255] is the normal way of saying foo[0:255]
- line 551: you actually need that extra line

review: Needs Fixing

« Back to merge proposal