Code review comment for lp:~salvatore-orlando/nova/bug723301

Revision history for this message
Brian Lamar (blamar) wrote :

> I can either replace BaseException with the exact types of exception I'm ready to handle or
> have smaller try/except blocks only for bits that I'm interesting in.
> Which approach would you suggest to be better (or should I probably have smaller try/except
> blocks catching only specific expections) ?

I'd love to see several smaller try/except blocks encapsulating the relevant calls. If/when this isn't possible you can catch multiple types of exceptions. If code can be shared between the except blocks then break those out into functions etc.

Thanks for the code!

« Back to merge proposal