Code review comment for lp:~salgado/offspring/trivialities
Revision history for this message
| Cody A.W. Somerville (cody-somerville) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
Makefile should be fixed. '[ -d builds ] && chmod -r builds' should be changed to something like 'chmod -r builds 2> /dev/null || true' or '[ ! -d builds ] || chmod -r builds'. The call to restore read permissions should be changed in a similar fashion.
For those curious why we do this, it is a hack to prevent distutils from transversing and accessing every single file underneath builds when we run setup.py. Although not problematic on a devel instance, it takes a significant amount of time in production where there are tons of files.