Code review comment for lp:~salgado/offspring/test-runner

On Thu, Sep 8, 2011 at 3:54 PM, Guilherme Salgado <
<email address hidden>> wrote:
<snip>

> === added directory 'lib/offspring/tests'
> === added file 'test.sh'
> --- test.sh 1970-01-01 00:00:00 +0000
> +++ test.sh 2011-09-08 19:53:46 +0000
> @@ -0,0 +1,6 @@
> +#!/bin/sh
> +
> +# Run all tests, excluding the ones under web.queuemanager.
> +.virtualenv/bin/nosetests -e 'queuemanager.*'
> +# Run the tests under web.queuemanager.
> +./bin/offspring-web test queuemanager
> --settings=offspring.web.settings_test
>

Is there any reason not to just add a new Makefile rule called 'test' to do
this? That way you can even make it make sure everything is setup plus
install nose.

Also, is there any benefit to using nose over updating setup.py so that you
can just run './setup.py test'?