Merge lp:~salgado/offspring/remove-more-dead-code into lp:offspring

Proposed by Guilherme Salgado
Status: Merged
Approved by: Cody A.W. Somerville
Approved revision: 85
Merged at revision: 86
Proposed branch: lp:~salgado/offspring/remove-more-dead-code
Merge into: lp:offspring
Diff against target: 41 lines (+0/-24)
1 file modified
lib/offspring/web/queuemanager/models.py (+0/-24)
To merge this branch: bzr merge lp:~salgado/offspring/remove-more-dead-code
Reviewer Review Type Date Requested Status
Cody A.W. Somerville Approve
Review via email: mp+77217@code.launchpad.net

Description of the change

Remove 4 unused methods: 3 from ProjectGroup and 1 from Project

To post a comment you must log in.
Revision history for this message
Cody A.W. Somerville (cody-somerville) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/offspring/web/queuemanager/models.py'
--- lib/offspring/web/queuemanager/models.py 2011-02-22 09:46:13 +0000
+++ lib/offspring/web/queuemanager/models.py 2011-09-27 18:45:28 +0000
@@ -110,24 +110,6 @@
110 return ">1 Day"110 return ">1 Day"
111 return "UNKNOWN"111 return "UNKNOWN"
112112
113 def latest_build(self):
114 try:
115 return BuildResult.objects.filter(project__project_group = self).exclude(result = None).exclude(started_at = None).latest()
116 except self.model.DoesNotExist:
117 return None
118
119 def latest_build_name(self):
120 try:
121 return self.latest_build().name
122 except self.model.DoesNotExist:
123 return u""
124
125 def latest_build_date(self):
126 try:
127 return self.latest_build().started_at
128 except self.model.DoesNotExist:
129 return u""
130
131113
132class Project(models.Model):114class Project(models.Model):
133 #XXX: This should probably be managed in the database.115 #XXX: This should probably be managed in the database.
@@ -202,12 +184,6 @@
202 except self.model.DoesNotExist:184 except self.model.DoesNotExist:
203 return None185 return None
204186
205 def latest_build_name(self):
206 try:
207 return self.latest_build().name
208 except self.model.DoesNotExist:
209 return u""
210
211 def latest_build_date(self):187 def latest_build_date(self):
212 try:188 try:
213 return self.latest_build().started_at189 return self.latest_build().started_at

Subscribers

People subscribed via source and target branches