Code review comment for lp:~salgado/offspring/private-projects

Revision history for this message
James Tunnicliffe (dooferlad) wrote :

Yep, http://bazaar.launchpad.net/~salgado/offspring/private-projects/revision/68
looks fine.

On 29 September 2011 19:15, Guilherme Salgado
<email address hidden> wrote:
> Thanks for the review, James.
>
> I've just noticed, though, that we must ensure the .all_objects manager is the one set as ._default_manager (used only internally by Django) or else the admin UI would hide all private objects and we would break model validation of unique fields if the user reuses a value from an object they are not allowed to see.  The revision I've just pushed addresses that and it'd be great if you could review it as well.
> --
> https://code.launchpad.net/~salgado/offspring/private-projects/+merge/76752
> Your team Linaro Infrastructure is requested to review the proposed merge of lp:~salgado/offspring/private-projects into lp:~linaro-infrastructure/offspring/linaro.
>

--
James Tunnicliffe

« Back to merge proposal