Code review comment for lp:~salgado/offspring/private-projects

Revision history for this message
Guilherme Salgado (salgado) wrote :

Thanks for the review, James.

I've just noticed, though, that we must ensure the .all_objects manager is the one set as ._default_manager (used only internally by Django) or else the admin UI would hide all private objects and we would break model validation of unique fields if the user reuses a value from an object they are not allowed to see. The revision I've just pushed addresses that and it'd be great if you could review it as well.

« Back to merge proposal