Code review comment for lp:~salgado/linaro-image-tools/remove-extra-get-devs-by-id-call
Revision history for this message
| Guilherme Salgado (salgado) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
On Fri, 2010-11-12 at 17:14 +0000, Peter Maydell wrote:
> I would prefer not to mix whitespace cleanup and semantic changes in the same commit...
And I would prefer that I didn't have to fix indentation and replace
<tab>s with spaces. ;)
In general I don't mix cleanup with semantic changes, but in this case
the semantic change is a one-liner, so I didn't bother. Anyway, I've
split that into a couple commits (r167 and r168) so they can be reviewed
(or reverted, if needed) independently.