Code review comment for lp:~salgado/linaro-image-tools/port-populate_boot

On Mon, 2010-12-06 at 22:21 +0000, Michael Hudson-Doyle wrote:
> Review: Approve
> I haven't checked every last detail for correctness, but I approve of
> the overall structure. Let me know if you want me to check all the
> arguments to each invocation of mkImage -- it can be done, but is
> probably a paper and pencil job.

I don't think that's necessary; I've checked it many times myself.

>
> I wonder if it would be easier to read if populate_boot took --options
> rather than positional arguments. I guess it depends how you see the
> code developing.

It'd probably be more readable, but soon enough we won't need any of
that as everything will be python, so I'd rather stick with whatever is
simpler until we get there.

>
> Thanks for working on this, linaro-media-create just makes me want to
> cry and this helps :-)

You're certainly not alone there.

Thanks for the review!