Code review comment for lp:~salgado/linaro-image-tools/populate-root

Revision history for this message
Guilherme Salgado (salgado) wrote :

IIUC, we were unsetting the CREATE_SWAP and SWAP_SIZE because further down the code would then be able to just check for their existence ([ "$CREATE_SWAP" ]) instead of checking for a specific value. Given that these things are now passed on to a python function, I want them to always exist, so I don't unset them anymore.

« Back to merge proposal