Merge lp:~salgado/linaro-image-tools/package-media-create into lp:linaro-image-tools/11.11

[Guilherme Salgado]

Make a .deb out of the media_create python package.

[Martin Ohlsson (martin-ohlson)]

+ Linaro images are generated by combining generic tarballs with
+ hardware-specific packs (hwpacks).
+ .
+ This package provides a python library to generate Linaro images and write
+ them to SD cards or image files that you can be boot in QEMU.

It looks like the word "be" before "boot in QEMU" shouldn't be there. And there seems to be a punctuation mark to much between the two sentences above.

Otherwise it look s good to me.

/Martin

review: Approve

[Guilherme Salgado (salgado)]

On Mon, 2010-12-06 at 13:32 +0000, Martin Ohlsson wrote:
> Review: Approve
> + Linaro images are generated by combining generic tarballs with
> + hardware-specific packs (hwpacks).
> + .
> + This package provides a python library to generate Linaro images and write
> + them to SD cards or image files that you can be boot in QEMU.
>
> It looks like the word "be" before "boot in QEMU" shouldn't be there. And there seems to be a punctuation mark to much between the two sentences above.

Indeed, that extra 'be' is leftover from a previous sentence I wrote,
but the line containing just the dot is, I think, a hack needed because
some of the packaging tools will drop blank lines. James can confirm
>
> Otherwise it look s good to me.

Thanks!

[James Westby (james-w)]

Hi,

It's usual to name the package after what you "import", so this would
be python-media-create I think.

You are correct about the blank lines.

Thanks,

James

[Guilherme Salgado (salgado)]

Ok, my only concern with that is python-media-create s too generic a name for a package, but then it's too generic a name for a module as well. Is that a big deal or is it ok to keep it as media-create for now?

[Loïc Minier (lool)]

I merged this, but then realized there were a number of small things which I changed subsequently:
- I added a dep on python-linaro-media-create to linaro-image-tools
- I dropped the dep on python-apt; I think this was a copy-paste from python-hwpack
- misc polish

[Guilherme Salgado (salgado)]

I didn't land this branch myself because there was one remaining
unresolved issue: the python package is called media_create whereas the
deb package is named python-linaro-media-create.

The easier thing to do would be to rename the deb to match the python
package's name, but media_create is too generic a name, so I wanted to
rename the python package to linaro_media_create.

[Loïc Minier (lool)]

I agree with you that media_create is too generic.

Would it make sense to rename the hwpack module+package as well for consistency?

=== modified file 'debian/control'
--- debian/control	2010-09-28 16:36:47 +0000
+++ debian/control	2010-12-06 13:15:27 +0000
@@ -34,3 +34,14 @@
  .
  This package provides a python library to aid with the creation of hardware
  packs.
+
+Package: python-linaro-media-create
+Architecture: all
+Section: python
+Depends: ${python:Depends}, python-apt, ${misc:Depends}
+Description: python library for the creation of Linaro bootable media
+ Linaro images are generated by combining generic tarballs with
+ hardware-specific packs (hwpacks).
+ .
+ This package provides a python library to generate Linaro images and write
+ them to SD cards or image files that you can be boot in QEMU.

=== added file 'debian/python-linaro-media-create.install'
--- debian/python-linaro-media-create.install	1970-01-01 00:00:00 +0000
+++ debian/python-linaro-media-create.install	2010-12-06 13:15:27 +0000
@@ -0,0 +1,1 @@
+usr/lib/python*/dist-packages/media_create

=== modified file 'debian/rules'
--- debian/rules	2010-09-24 20:37:48 +0000
+++ debian/rules	2010-12-06 13:15:27 +0000
@@ -4,4 +4,6 @@
 	dh --buildsystem=python_distutils --with-addon=python-support $*
 
 override_dh_auto_test:
-	python -m testtools.run hwpack.tests.test_suite
+	# XXX: The test-suite currently fails on Lucid. What can we do about
+	# it?
+	python -m testtools.run tests.test_suite

=== modified file 'setup.py'
--- setup.py	2010-09-24 20:37:48 +0000
+++ setup.py	2010-12-06 13:15:27 +0000
@@ -20,5 +20,5 @@
 setup(
         name="hwpack",
         version=get_version(),
-        packages=["hwpack"],
+        packages=["hwpack", "media_create"],
      )