Code review comment for lp:~salgado/linaro-image-tools/improve-cmd_runner

Revision history for this message
James Westby (james-w) wrote :

Looks good thanks.

This is assuming that other things than wait() aren't used (e.g. communicate()),
but I think that's ok.

Plus communicate() would be trickier to do like this anyway.

Thanks,

James

review: Approve

« Back to merge proposal