30 +TEMP_DIR="/var/tmp/hwpack"
it would be good to have that not be static, and create a tempdir with an unpredictable name, using e.g. mktemp.
64 + sudo rm -f $HWPACK_PKGS_SOURCE 65 + sudo apt-get update -qq
I don't see why sudo would be needed? This will run as root won't it?
101 +for file in `ls "${HWPACK_DIR}"/sources.list.d.gpg/`; do
This can use a * expansion as the sources.list.d code does couldn't it?
Otherwise this looks good. Short and sweet and we should try and keep it that way.
Thanks,
James
« Back to merge proposal
30 +TEMP_DIR= "/var/tmp/ hwpack"
it would be good to have that not be static, and create a tempdir
with an unpredictable name, using e.g. mktemp.
64 + sudo rm -f $HWPACK_PKGS_SOURCE
65 + sudo apt-get update -qq
I don't see why sudo would be needed? This will run as root won't it?
101 +for file in `ls "${HWPACK_ DIR}"/sources. list.d. gpg/`; do
This can use a * expansion as the sources.list.d code does couldn't it?
Otherwise this looks good. Short and sweet and we should try and keep
it that way.
Thanks,
James