Code review comment for lp:~salgado/linaro-image-tools/fix-mocking

Revision history for this message
Guilherme Salgado (salgado) wrote :

On Fri, 2010-12-03 at 18:11 +0000, James Westby wrote:
> Review: Approve
> Hi,
>
> I think this is a good change, thanks.
>
> 47 +class MockSomethingFixture(object):
>
> Maybe MockAttributeFixture?

I thought about that but then it may mislead one into thinking it can
not mock functions/objects.

>
> We might also want a specific subclass for do_run, as I expect that will
> be used a lot?

Yes, that makes sense. I've created that.

Thanks for the review!

« Back to merge proposal