Code review comment for lp:~salgado/linaro-image-tools/cmd-runner

On Wed, 01 Dec 2010 17:43:52 -0000, Guilherme Salgado <email address hidden> wrote:
> Right, but my point here is that callsites may forget to check the
> return-value, silently ignoring errors in sub-processes. If we agree
> it's fair to assume that any sub-process that returns non-zero should
> cause the script to abort, then in that case raising an exception on
> non-zero return codes is the best way to ensure it always happens.
>
> Callsites can (and should) catch these exceptions and report meaningful
> errors but I don't like the idea of relying solely on callsites for
> that.

+1

> That's possible, but I'd prefer if we add these new bits as they become
> necessary.

+1

Thanks,

James