Code review comment for lp:~salgado/linaro-image-tools/cmd-runner
Revision history for this message
| James Westby (james-w) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
Hi,
15 + if isinstance(command, (list, tuple)):
16 + command = " ".join(command)
Do we want to do this and risk bugs with shell quoting?
24 + # XXX: Should we raise an error when the return code is not 0, so that it
25 + # behaves like the original shell script which was run with 'set -e'?
I think so.
Do we need shell=True? I assume we do, but using it as little as possible
would be good.
Thanks,
James