Code review comment for lp:~salgado/linaro-image-tools/check-hwpack-format

On Fri, 2010-10-08 at 02:16 +0000, James Westby wrote:
> Review: Approve
> Hi,
>
> Looks good to me. I just wonder what
>
> for format in $SUPPORTED_FORMATS; do
>
> requires SUPPORTED_FORMATS to be set to when there are multiple. Does
> space-separated work, or does it need to be newline-separated?

By default it will work with space/tab/newline separated values as
that's the default value for $IFS, but now I'm wondering if it's ok to
rely on that or if we should explicitly set it to whatever we want
(space, in this case) around the for loop.

>
> Maybe want to put a hint about trying a newer linaro-hwpack-install
> script in the error message?

That sounds like a good idea; I'll do it.