Code review comment for lp:~salgado/linaro-image-tools/check-hwpack-format

Revision history for this message
James Westby (james-w) wrote :

Hi,

Looks good to me. I just wonder what

for format in $SUPPORTED_FORMATS; do

requires SUPPORTED_FORMATS to be set to when there are multiple. Does
space-separated work, or does it need to be newline-separated?

Maybe want to put a hint about trying a newer linaro-hwpack-install
script in the error message?

Thanks,

James

review: Approve

« Back to merge proposal