Code review comment for lp:~salgado/linaro-image-tools/bug-697824

> It's much longer than I had hoped for a temporary workaround, but it's all
> tested so that's nice!
>
> One thing which is a bit odd is that we do the runtime serialtty only for OMAP
> boards, so that it looks like:
> + _serial_tty = 'ttyO2'
> + _extra_serial_opts = 'console=tty0 console=%s,115200n8'
> + _live_serial_opts = 'serialtty=%s'
>
> for OMAP boards and like this for non-OMAP boards:
> + serial_tty = 'ttyAMA2'
> + extra_serial_opts = 'console=tty0 console=%s,115200n8' % serial_tty
> + live_serial_opts = 'serialtty=%s' % serial_tty
>
> could we just use the same approach for all boards (i.e. do all boards at
> runtime) as to have the same structure for all configs?

That's because OMAP configs are the exception, but once this hack is reverted they will look just like the other ones. The special case in the OMAP config is even described in an XXX comment (with a mention to the bug) to make it clear why it's different. But maybe you're anticipating some sort of problems we might have because of the different structure?