Code review comment for lp:~salgado/linaro-image-tools/bug-673412

On Wed, 05 Jan 2011 18:22:51 -0000, Guilherme Salgado <email address hidden> wrote:
> On Wed, 2011-01-05 at 17:32 +0000, James Westby wrote:
> > Review: Needs Information
> > 29 + if filesystem in open('/proc/mounts').read():
> >
> > Is that a bit broad? It would cause an error if the filesystem showed
> > up in there in a strange place wouldn't it?
>
> I find it highly unlikely that a /dev/{sdXX,mmcblkNpN,loopN} string
> (which is usually what the function will be given) ends up there unless
> the filesystem is mounted, but I can use UDisks to do a more specific
> check.

Yeah, it's rare. I'm happy with this going in as is and we can see if we
get any fallout.

Thanks,

James