On Wed, 2011-01-05 at 17:32 +0000, James Westby wrote:
> Review: Needs Information
> 29 + if filesystem in open('/proc/mounts').read():
>
> Is that a bit broad? It would cause an error if the filesystem showed
> up in there in a strange place wouldn't it?
I find it highly unlikely that a /dev/{sdXX,mmcblkNpN,loopN} string
(which is usually what the function will be given) ends up there unless
the filesystem is mounted, but I can use UDisks to do a more specific
check.
On Wed, 2011-01-05 at 17:32 +0000, James Westby wrote: proc/mounts' ).read( ):
> Review: Needs Information
> 29 + if filesystem in open('/
>
> Is that a bit broad? It would cause an error if the filesystem showed
> up in there in a strange place wouldn't it?
I find it highly unlikely that a /dev/{sdXX, mmcblkNpN, loopN} string
(which is usually what the function will be given) ends up there unless
the filesystem is mounted, but I can use UDisks to do a more specific
check.