Code review comment for lp:~salgado/lazr.delegates/extend-passthrough

Revision history for this message
Gary Poster (gary) wrote :

merge-conditional

Looks great. A few remaining trivial cleanups.

orig_interface -> adaptation in "Passthrough's third argument (orig_interface) is optional..." (src/lazr/delegates/README.txt)

"...(although in practice anything that provides a __call__() method will do)..." -> "...(although in practice any callable will do)..." (src/lazr/delegates/README.txt)

"If adaptation is not None, the context is adapted into it before getting/setting the attribute." -> "If the ``adaptation`` argument is not None, it should be a callable. It will be called with the context, and should return an object that will have the delegated attribute. The ``adaptation`` argument is expected to be used with an interface, to adapt the context." (src/lazr/delegates/_delegates.py)

Thank you!

Gary

review: Approve

« Back to merge proposal