Merge lp:~salgado/lava-dashboard/csrf-on-django1.1 into lp:lava-dashboard
Proposed by
Guilherme Salgado
Status: | Rejected |
---|---|
Rejected by: | Loïc Minier |
Proposed branch: | lp:~salgado/lava-dashboard/csrf-on-django1.1 |
Merge into: | lp:lava-dashboard |
Diff against target: |
12 lines (+1/-1) 1 file modified
dashboard_server/default_settings.py (+1/-1) |
To merge this branch: | bzr merge lp:~salgado/lava-dashboard/csrf-on-django1.1 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Loïc Minier (community) | Needs Resubmitting | ||
Zygmunt Krynicki (community) | Approve | ||
Review via email: mp+38588@code.launchpad.net |
Description of the change
This typo means we don't have CSRF protection on 1.1
I'd fixed it as part of another branch of mine, but doing so causes 3
django.contrib.auth tests to fail on Lucid, so I'm proposing it separately for
discussion.
To post a comment you must log in.
Unmerged revisions
- 95. By Guilherme Salgado
-
Fix a typo on dashboard_
server/ default_ settings. py
Auth tests fail on lucid because of unrelated reason (note that james sent an email about a package in -proposed that fixes this). So unless I misunderstood there is nothing that prevents this fix from landing.