Code review comment for lp:~salgado/launchpad/use-meliae

Revision history for this message
Guilherme Salgado (salgado) wrote :

On Thu, 2010-03-18 at 19:48 +0000, Francis J. Lacoste wrote:
> Review: Needs Information
> * Don't we need to add meliae to the buildout?

We could, but since we already have it packaged in Lucid (I just
backported the package to Karmic and Hardy) and the release tarball is
not eggified, I thought I'd go with the easiest option. After all, if
we need a newer version we can easily switch to using an egg.

> * Can we use a configurable file instead of an hardcoded one?

I considered that, but I couldn't come up with any use cases that would
require changing the file path. I also try to use config values only
for things that change between environments -- which doesn't seem to be
the case here.

--
Guilherme Salgado <email address hidden>

« Back to merge proposal