Code review comment for lp:~salgado/launchpad/remove-IDBSchema

On August 7, 2009, Guilherme Salgado wrote:
> + # XXX: salgado, 2009-08-07:
> + # We shouldn't have to build our vocabulary out of
> (item.title, + # item) tuples -- iterating over an
> EnumeratedType gives us + # ITokenizedTerms that we could use.
> However, the terms generated + # by EnumeratedType have their
> name as the token and there are + # plenty of tests that expect
> the title as the token.

Hi Salgado,

Good clean-up job.

My only gripe is that XXX should require a bug number. If this is something
that we truly want to change (and break all scripts used to using titles to
pass in status value), then file one. Otherwise, don't use an XXX there.

  status approved
  review approve

Cheers

--
Francis J. Lacoste
<email address hidden>