Code review comment for lp:~salgado/launchpad/real-breadcrumbs

Revision history for this message
Guilherme Salgado (salgado) wrote :

= Summary =

The Breadcrumb adapter doesn't honor the rootsite specified in ICanonicalUrlData

== Proposed fix ==

Change Breadcrumb.rootsite into a property that looks for a rootsite for
its given object in the ICanonicalUrlData of that object, falling back
to 'mainsite' if it's not defined for that object.

This is a fix for bug 418214

== Tests ==

./bin/test -vvt test_breadcrumbs

== Demo and Q/A ==

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/canonical/launchpad/webapp/tests/test_breadcrumbs.py
  lib/canonical/launchpad/webapp/breadcrumb.py
  lib/lp/bugs/browser/bugtask.py

== Pylint notices ==

lib/lp/bugs/browser/bugtask.py
    1232: [C0301] Line too long (79/78)
    92: [F0401] Unable to import 'lazr.uri' (No module named uri)

« Back to merge proposal