Code review comment for lp:~salgado/launchpad/person-three-o

Revision history for this message
Guilherme Salgado (salgado) wrote :

= Summary =

Convert person-index.pt to UI 3.0

Some screenshots:

http://people.canonical.com/~salgado/person1.png
http://people.canonical.com/~salgado/person2.png
http://people.canonical.com/~salgado/person3.png

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/registry/templates/person-portlet-contributions.pt
  lib/lp/registry/browser/configure.zcml
  lib/canonical/launchpad/pagetitles.py
  lib/lp/registry/templates/person-portlet-memberships.pt
  lib/lp/registry/templates/person-portlet-contact-details.pt
  lib/lp/registry/templates/person-portlet-currentfocus.pt
  lib/lp/registry/templates/team-members.pt
  lib/lp/registry/templates/teammembership-listing-simple.pt
  lib/lp/registry/templates/teammembership-index.pt
  lib/lp/registry/templates/person-index.pt
  lib/lp/registry/browser/person.py
  lib/lp/soyuz/templates/person-portlet-ppas.pt

== Pylint notices ==

lib/lp/registry/browser/person.py
    119: [F0401] Unable to import 'lazr.delegates' (No module named
delegates)
    120: [F0401] Unable to import 'lazr.config' (No module named config)
    121: [F0401] Unable to import 'lazr.restful.interface' (No module
named restful)

« Back to merge proposal