Code review comment for lp:~salgado/launchpad/person-edit-pages

Revision history for this message
Michael Nelson (michael.nelson) wrote :

r=me

The changes look straight-forward.

I noticed that there are breadcrumbs present for:

https://launchpad.dev/projects/+new

that were not present in your screenshots? Displaying like:

Projects >> +new

I'm not sure why they're not in your screenshots, or whether the +new is the correct way they should display? (I would have expected Projects >> New - if anything) But I'm guessing its a result of something else that you've landed recently, so it's probably right - just check if it's what you expected. I can see even this MP page now has: 'Launchpad itself >> +reply'. (I'll try to catch up on my email and see where it was mentioned!)

review: Approve (code)

« Back to merge proposal