Code review comment for lp:~salgado/launchpad/person-edit-pages

Revision history for this message
Guilherme Salgado (salgado) wrote :

= Summary =

https://bugs.edge.launchpad.net/launchpad-registry/+bug/421978

== Proposed fix ==

Mechanical changes to convert the pages. Screenshots:
http://people.canonical.com/~salgado/project

The UI has been approved by Martin A. already.

== Pre-implementation notes ==

== Implementation details ==

== Tests ==

== Demo and Q/A ==

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/canonical/launchpad/pagetitles.py
  lib/lp/registry/templates/product-purchase-subscription.pt
  lib/lp/registry/browser/product.py
  lib/lp/registry/templates/product-new.pt
  lib/lp/registry/browser/person.py
  lib/lp/registry/templates/person-vouchers.pt

== Pylint notices ==

lib/lp/registry/browser/product.py
    55: [F0401] Unable to import 'lazr.delegates' (No module named delegates)

lib/lp/registry/browser/person.py
    120: [F0401] Unable to import 'lazr.delegates' (No module named delegates)
    121: [F0401] Unable to import 'lazr.config' (No module named config)
    122: [F0401] Unable to import 'lazr.restful.interface' (No module named restful)

« Back to merge proposal