Launchpad itself

Code review comment for lp:~salgado/launchpad/edge-redirect-bugs

  1. edge-redirect-bugs
  2. Merge into devel
Revision history for this message
Guilherme Salgado (salgado) wrote :

On Wed, 2010-03-10 at 14:42 -0300, Guilherme Salgado wrote:
> > > === modified file 'lib/canonical/launchpad/templates/launchpad-requestexpired.pt'
> > > --- lib/canonical/launchpad/templates/launchpad-requestexpired.pt 2009-07-28 17:19:42 +0000
> > > +++ lib/canonical/launchpad/templates/launchpad-requestexpired.pt 2010-03-10 16:32:41 +0000
> > > @@ -9,27 +9,16 @@
> > > <body>
> > > <div class="top-portlet" metal:fill-slot="main">
> > > <h1 class="exception">Timeout error</h1>
> > > - <div
> > > - id="redirect_notice" style="display:none" class="informational message">
> > > - <p>Our edge server has a lower timeout threshold than launchpad.net,
> > > - so we can catch those before they hit a wider audience.
> > > - As a member of the Launchpad Beta Testers team, you're more
> > > - likely to experience them. If this is blocking your work, you
> > > - can disable redirection.</p>
> > > - <p><button onclick="setBetaRedirect(false)">Disable redirection
> > > - for 2 hours</button></p>
> > > + <div tal:condition="is_edge"
> > > + id="redirect_notice" class="informational message">
> > > + <p>Our edge server has a lower timeout threshold than launchpad.net,
> > > + so we can catch those before they hit a wider audience.
> > > + As a member of the Launchpad Beta Testers team, you're more
> >
> > You haven't changed it, but this isn't strictly true - that the viewer
> > is a beta tester - any more is it? Doesn't matter much though.
>
> You're right. How about this:
>
> <p>Our edge server has a lower timeout threshold than launchpad.net,
> so we can catch those before they hit a wider audience.
> If this is blocking your work, you can disable automatic redirection
> to edge in order to use launchpad.net.</p>
> ?

Or maybe

    If this is blocking your work and you are a member of the Launchpad
    Beta Testers team, you can disable automatic redirection
    to edge in order to use launchpad.net.</p>

« Back to merge proposal