Code review comment for lp:~salgado/launchpad/easier-read-only-switch

Revision history for this message
Gary Poster (gary) wrote :

Tom, I asked you for a review so that we could discuss QA.

I think we're delivering exactly what we discussed, but I'd also like verification of that as well. As Salgado says, if you add a read-only.txt to the top the tree, or remove it, the application should notice as soon as it processes a new request. It will then acknowledge the change in the main launchpad.log. Because our requests time out in about 15 seconds, webapp machines should be ready to switch easily within a minute. This does not affect long running processes, which would presumably need to be stopped when switching to readonly, and restarted when resuming (as usual?).

« Back to merge proposal