Code review comment for lp:~salgado/launchpad/cleanup-breadcrumbs

Revision history for this message
Guilherme Salgado (salgado) wrote :

= Summary =

Most of our IBreadcrumb adapters define just a text property that
returns the context's title or displayname, so I defined some generic
adapters that do just that and used them instead, removing the existing
ones.

The field_names variable removed is because it was redefined a few lines
below. Also, the lint issues on browser/person.py have been fixed on
another branch of mine, so I won't fix them here.

== Tests ==

./bin/test -vvt test_breadcrumbs

== Demo and Q/A ==

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/bugs/configure.zcml
  lib/lp/registry/browser/product.py
  lib/lp/registry/configure.zcml
  lib/canonical/launchpad/webapp/breadcrumb.py
  lib/lp/soyuz/configure.zcml
  lib/lp/blueprints/configure.zcml
  lib/lp/blueprints/browser/sprint.py
  lib/lp/bugs/browser/bugtracker.py
  lib/lp/soyuz/browser/builder.py
  lib/lp/translations/configure.zcml
  lib/lp/translations/browser/translationgroup.py
  lib/lp/registry/browser/person.py
  lib/lp/registry/browser/distribution.py
  lib/lp/registry/browser/project.py
  lib/lp/soyuz/browser/archive.py

== Pylint notices ==

lib/lp/registry/browser/product.py
    54: [F0401] Unable to import 'lazr.delegates' (No module named delegates)

lib/lp/soyuz/browser/builder.py
    44: [F0401] Unable to import 'lazr.delegates' (No module named delegates)

lib/lp/registry/browser/person.py
    1186: [C0301] Line too long (79/78)
    1273: [C0301] Line too long (79/78)
    3120: [W0311] Bad indentation. Found 10 spaces, expected 12
    3124: [W0311] Bad indentation. Found 10 spaces, expected 12
    119: [F0401] Unable to import 'lazr.delegates' (No module named delegates)
    120: [F0401] Unable to import 'lazr.config' (No module named config)
    121: [F0401] Unable to import 'lazr.restful.interface' (No module named restful)

« Back to merge proposal