Very nicely done. Good advice to look at the two revisions separately, thank you.
My only suggestion is to add a comment within processPositiveAssertion for the code that creates an account when there was a positive OpenId assertion but no Account--something that just says what the code path is for. On this order:
# We got an OpenID response containing a positive assertion, but we don't have an account for the identifier. We'll create one.
Very nicely done. Good advice to look at the two revisions separately, thank you.
My only suggestion is to add a comment within processPositive Assertion for the code that creates an account when there was a positive OpenId assertion but no Account--something that just says what the code path is for. On this order:
# We got an OpenID response containing a positive assertion, but we don't have an account for the identifier. We'll create one.
Thank you!
Gary