Code review comment for lp:~salgado/launchpad/bug-538207

Revision history for this message
Aaron Bentley (abentley) wrote :

The code looks good, but your comments about E1002 are irrelevant to the issue. TestWebServiceRequestTraversal, TestVhostWebserviceFactory, FeedsPublication, WebServicePublication, PrivateXMLRPCPublication and ProtocolErrorPublication are all derived from classes defined outside their file, and so their status as new-style classes is determined by the classes they derive from. __metaclass__ = type has absolutely no impact on these classes.

review: Approve

« Back to merge proposal