Merge lp:~salgado/launchpad/bug-422552 into lp:launchpad
Proposed by
Guilherme Salgado
Status: | Merged |
---|---|
Approved by: | Brad Crittenden |
Approved revision: | not available |
Merged at revision: | not available |
Proposed branch: | lp:~salgado/launchpad/bug-422552 |
Merge into: | lp:launchpad |
Diff against target: |
29 lines (+7/-1) 2 files modified
lib/canonical/launchpad/scripts/tests/test_librarian_apache_log_parser.py (+6/-0) lib/lp/services/apachelogparser/base.py (+1/-1) |
To merge this branch: | bzr merge lp:~salgado/launchpad/bug-422552 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brad Crittenden (community) | code | Approve | |
Review via email:
|
To post a comment you must log in.
= Summary =
As seen in the logs of the script which parses librarian log files to
count downloads, there are errors when parsing some lines. These errors
prevent the script from parsing the remaining of the files.
The error happens when the request string has multiple consecutive white
spaces.
== Proposed fix ==
Fix the bug by normalizing white spaces in the request string
= Launchpad lint =
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
Linting changed files: /launchpad/ scripts/ tests/test_ librarian_ apache_ log_parser. py services/ apachelogparser /base.py
lib/canonical
lib/lp/
== Pylint notices ==
lib/lp/ services/ apachelogparser /base.py
11: [F0401] Unable to import 'lazr.uri' (No module named uri)